Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom validation to form #48

Merged

Conversation

Amnish04
Copy link
Contributor

@Amnish04 Amnish04 commented Oct 21, 2023

I have added custom validation features to the input elements.

The Generate Card button gets dynamically enabled only if:

  1. All the properties marked as required have been entered.
  2. At least one of the social media link has been entered and is of correct format.
  3. All the input elements are in valid state.

Please review my changes, and let me know if something needs to be changed.

This closes #47

Update: I just added * symbol before labels for every required field.

Copy link
Owner

@piyushkdas0611 piyushkdas0611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, do star repo

@piyushkdas0611 piyushkdas0611 merged commit cea57c0 into piyushkdas0611:main Oct 21, 2023
1 of 2 checks passed
@Amnish04
Copy link
Contributor Author

Amnish04 commented Oct 21, 2023

@piyushkdas0611 You're welcome. Just one thing, could you please add hacktoberfest-accepted label to the PR as well? For some reason, its not counting towards my progress.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Adding input validations to the form
2 participants