Use arel_table instead of table_name and class_eval. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scope (and default_scope) without lambda have been deprecated in Rails 4. This change fixes that and also removes support for Rails 2.
This is to ensure that the scopes can be correctly chained upon other scopes and work correctly across joins.
|
@pjb3 This is legit. Will you merge? |
pjb3
added a commit
that referenced
this pull request
Jan 14, 2014
Use arel_table instead of table_name and class_eval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to ensure that the scopes can be correctly chained upon other scopes and work correctly across joins.
(This builds on #12)