Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support vendoring #7

Merged
merged 1 commit into from Dec 3, 2022
Merged

Support vendoring #7

merged 1 commit into from Dec 3, 2022

Conversation

yann-soubeyrand
Copy link
Contributor

Hello,

When using Go modules vendoring, I get an error during build:

# github.com/pjbgf/sha1cd/cgo
vendor/github.com/pjbgf/sha1cd/cgo/sha1.go:3:11: fatal error: lib/sha1.h: No such file or directory
    3 | // #include <lib/sha1.h>
      |           ^~~~~~~~~~~~
compilation terminated.

If I understood correctly, this is due to the fact that vendoring doesn’t take into account subdirectories (in this case the lib subdirectory).

This PR is an attempt at fixing this issue.

@yann-soubeyrand yann-soubeyrand mentioned this pull request Dec 2, 2022
Closed
pjbgf
pjbgf approved these changes Dec 3, 2022
View reviewed changes
Copy link
Owner

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Great stuff @yann-soubeyrand! Thank you for the timely fix. 🙇

@pjbgf pjbgf merged commit c520523 into pjbgf:main Dec 3, 2022
@pjbgf pjbgf mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjbgf pjbgf pjbgf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yann-soubeyrand @pjbgf