Skip to content

Commit

Permalink
import Devel::Cover 0.10
Browse files Browse the repository at this point in the history
  • Loading branch information
pjcj committed Nov 3, 2004
1 parent 6649f9f commit 69a8165
Show file tree
Hide file tree
Showing 14 changed files with 512 additions and 201 deletions.
3 changes: 3 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ Release 0.08 - 18th August 2001

Release 0.09 - 18th August 2001
- Beef up Devel::Cover::DB.

Release 0.10 - 27th August 2001
- Add cover program to generate reports.
185 changes: 16 additions & 169 deletions Cover.pm
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ use warnings;

use DynaLoader ();

use Devel::Cover::DB 0.09;
use Devel::Cover::Inc 0.09;
use Devel::Cover::DB 0.10;
use Devel::Cover::Inc 0.10;

our @ISA = qw( DynaLoader );
our $VERSION = "0.09";
our $VERSION = "0.10";

use B qw( class ppname main_root main_start main_cv svref_2object OPf_KIDS );
# use B::Debug;
Expand Down Expand Up @@ -137,6 +137,11 @@ sub get_location
# If there's an eval, get the real filename. Enabled from $^P & 0x100.

($F, $L) = ($1, $2) if $F =~/^\(eval \d+\)\[(.*):(\d+)\]/;

# print STDERR "<$F> => ";
$F =~ s/ \(autosplit into .*\)$//;
# print STDERR "<$F>\n";

}

sub walk_topdown
Expand Down Expand Up @@ -330,9 +335,13 @@ Code coverage data are collected using a plugable runops function which
counts how many times each op is executed. These data are then mapped
back to reality using the B compiler modules.
The B<cover> program can be used to generate coverage reports.
At the moment, only statement coverage and condition coverage
information is reported. Coverage data for other metrics are collected,
but not reported. Coverage data for some metrics are not yet collected.
information is reported. Condition coverage data is not accurate at the
moment, but statement coverage data should be reasonable. Coverage data
for other metrics are collected, but not reported. Coverage data for
some metrics are not yet collected.
You may find that the results don't match your expectations. I would
imagine that at least one of them is wrong.
Expand All @@ -353,169 +362,6 @@ Requirements:
-select RE - Only report on files matching RE.
-summary val - Print summary information iff val is true (default on).
=head1 TUTORIAL
Here's part of a message I sent to perl-qa about code coverage metrics.
=head2 1.0 Introduction
It is wise to remember the following quote from Dijkstra, who said:
Testing never proves the absence of faults, it only shows their presence.
In particular, code coverage is just one weapon in the software engineer's
testing arsenal.
Any discussion of code coverage metrics is hampered by the fact that
many authors use different terms to describe the same kind of coverage.
Here, I shall provide only a brief introduction to some of the most
common metrics.
=head2 2.0 Metrics
=head2 2.1 Statement coverage
This is the most basic form of code coverage. A statement is covered if
it is executed. Note that statement != line of code. Multiple
statements on a single line can confuse issues - the reporting if
nothing else.
Where there are sequences of statements without branches it is not
necessary to count the execution of every statement, just one will
suffice, but people often like the count of every line to be reported,
especially in summary statistics. However it is not clear to me that
this is actually useful.
This type of coverage is fairly weak in that even with 100% statement
coverage there may still be serious problems in a program which could be
discovered through other types of metric.
It can be quite difficult to achieve 100% statement coverage. There may
be sections of code designed to deal with error conditions, or rarely
occurring events such as a signal received during a certain section of
code. There may also be code that should never be executed:
if ($param > 20)
{
die "This should never happen!";
}
It can be useful to mark such code in some way and flag an error if it
is executed.
Statement coverage, or something very similar, can be called statement
execution, line, block, basic block or segment coverage. I tend to
favour block coverage which does not attempt to extend its results to
each statement.
=head2 2.2 Branch coverage
The goal of branch coverage is to ensure that whenever a program can
jump, it jumps to all possible destinations. The most simple example is
a complete if statement:
if ($x)
{
print "a";
}
else
{
print "b";
}
In such a simple example statement coverage is as powerful, but branch
coverage should also allow for the case where the else part is missing:
if ($x)
{
print "a";
}
Full coverage is only achieved here if $x is true on one occasion and
false on another.
100% branch coverage implies 100% statement coverage.
Branch coverage is also called decision or all edges coverage.
=head2 2.3 Path coverage
There are classes of errors that branch coverage cannot detect, such as:
$h = undef;
if ($x)
{
$h = { a => 1 };
}
if ($y)
{
print $h->{a};
}
100% branch coverage can be achieved by setting ($x, $y) to (1, 1) and then
to (0, 0). But if we have (0, 1) then things go bang.
The purpose of path coverage is to ensure that all paths through the
program are taken. In any reasonably sized program there will be an
enormous number of paths through the program and so in practice the
paths can be limited to a single subroutine, if the subroutine is not
too big, or simply to two consecutive branches.
In the above example there are four paths which correspond to the truth
table for $x and $y. To achieve 100% path coverage they must all be
taken. Note that missing elses count as paths.
In some cases it may be impossible to achieve 100% path coverage:
a if $x;
b;
c if $x;
50% path coverage is the best you can get here.
Loops also contribute to paths, and pose their own problems which I'll
ignore for now.
100% path coverage implies 100% branch coverage.
Path coverage and some of its close cousins, are also known as
predicate, basis path and LCSAJ (Linear Code Sequence and Jump)
coverage.
=head2 2.4 Expression coverage
When a boolean expression is evaluated it can be useful to ensure that
all the terms in the expression are exercised. For example:
a if $x || $y
The expression should be exercised with ($x, $y) set to (0, 0) (required
for branch coverage), (0, 1) and (1, 0) (to ensure that $x and $y are
independent) and possibly with (1, 1).
Expression coverage gets complicated, and difficult to achieve, as the
expression gets complicated.
Expressions which are not directly a part of a branching construct
should also be covered:
$z = $x || $y;
a if $z;
Expression coverage is also known as condition, condition-decision and
multiple decision coverage.
=head2 3.0 Other considerations
In order to get people to actually use code coverage it needs to be
simple to use. It should also be simple to understand the results and
to rectify any problems thrown up. Finally, if the overhead is too
great it won't get used either.
So there's a basic tutorial on code coverage, or at least my version of
it. Typing a few of these terms into google will probably provide a
basis for future research.
=head1 ACKNOWLEDGEMENTS
Some code and ideas cribbed from:
Expand All @@ -526,6 +372,7 @@ Some code and ideas cribbed from:
=head1 SEE ALSO
Devel::Cover::Tutorial
Data::Dumper
B
Expand All @@ -535,7 +382,7 @@ Huh?
=head1 VERSION
Version 0.09 - 18th August 2001
Version 0.10 - 27th August 2001
=head1 LICENCE
Expand Down
17 changes: 16 additions & 1 deletion Cover.xs
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ runops_cover(pTHX)
if (!hv) hv = newHV();
addr.ch[sizeof(PL_op)] = '\0';

// fprintf(stderr, "runops_cover\n");
while ((PL_op = CALL_FPTR(PL_op->op_ppaddr)(aTHX)))
{
if (covering)
Expand All @@ -53,6 +54,19 @@ runops_cover(pTHX)
return 0;
}

static int
runops_orig(pTHX)
{
// fprintf(stderr, "runops_orig\n");
while ((PL_op = CALL_FPTR(PL_op->op_ppaddr)(aTHX)))
{
PERL_ASYNC_CHECK();
}

TAINT_NOT;
return 0;
}

MODULE = Devel::Cover PACKAGE = Devel::Cover

PROTOTYPES: ENABLE
Expand All @@ -61,7 +75,8 @@ void
set_cover(flag)
int flag
PPCODE:
covering = flag;
// fprintf(stderr, "Cover set to %d\n", flag);
PL_runops = (covering = flag) ? runops_cover : runops_orig;

SV *
coverage()
Expand Down
4 changes: 2 additions & 2 deletions Cover/DB.pm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use Carp;
use Data::Dumper;
use File::Path;

our $VERSION = "0.09";
our $VERSION = "0.10";

my $DB = "cover.1"; # Version 1 of the database.

Expand Down Expand Up @@ -472,7 +472,7 @@ Huh?
=head1 VERSION
Version 0.09 - 18th August 2001
Version 0.10 - 27th August 2001
=head1 LICENCE
Expand Down
2 changes: 1 addition & 1 deletion Cover/Op.pm
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ package Devel::Cover::Op;
use strict;
use warnings;

our $VERSION = "0.09";
our $VERSION = "0.10";

use Devel::Cover qw( -inc B -indent 1 -details 1 );
use B::Concise qw( set_style add_callback );
Expand Down
Loading

0 comments on commit 69a8165

Please sign in to comment.