Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support stats property from Metalsmith 0.10+ #2

Closed
pjeby opened this issue Sep 22, 2014 · 1 comment
Closed

Support stats property from Metalsmith 0.10+ #2

pjeby opened this issue Sep 22, 2014 · 1 comment
Labels
enhancement
Milestone
0.5.0

Comments

@pjeby
Copy link
Owner

pjeby commented Sep 22, 2014

Per issue #1, file conversions need to:

  • Create the Metal .stats property from Vinyl .stat (if present)
  • Create the Vinyl .stat from Metal .stats (if present)
  • Override the Vinyl stat's mode with Metal mode (so you can change the mode)

Also, there appears to be a bug in the current code whereby a .stat property on a Metal file can bleed into a Vinyl file if the Metal file lacks a .mode -- should probably add a test for that.

(And of course, all the conversion docs and tests need updating.)
@pjeby pjeby added this to the 0.5.0 milestone Sep 22, 2014
pjeby added a commit that referenced this issue Sep 22, 2014
@pjeby
0.5.0: Implement #2: stats property for Metalsmith 0.10+
35807c2
@pjeby
Copy link
Owner Author

pjeby commented Sep 22, 2014

Implemented in 35807c2 and released as 0.5.0

@pjeby pjeby closed this as completed Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@pjeby