Scoping issue with "no autodie" and the "system" sub

[nthykier]

Hi,

We saw a report in Debian (https://bugs.debian.org/798096), where autodie broke valid code.

The code can basically be reduced to:

#!/usr/bin/perl

use autodie;

use_system();

sub break_system {
    no autodie qw(system);
}

sub use_system {
    system('/bin/true');
}

A couple items to note:

• The order of break_system and use_system is significant (reorder them and the problem disappears)
• It appears to affect system() but not chdir() [have not tested other functions yet]
• It also appears if you replace "no autodie qw(${sub})" with a plain "no autodie".

[nthykier]

The error received is:

 $ ./test.pl 
Undefined subroutine called at ./test.pl line 12.

[ntyni]

Hi, please see the pull request I just linked. I'm not quite sure if it's correct but it seems to work.

[ntyni]

Taking that back: the change only works on the 'main' package so it still needs some more work :)

[ntyni]

Hi, ntyni@c1b4fc4 is my next try and passes all tests, but I'm not sure about this:

FIXME: if the original sub 'can be undef for "CORE::" subs', does this break for those? Is that the case when $symbol =~ /::/, as guarded on L566?

Help/comments would be welcome.

[nthykier]

Fixed by the merge of c1b4fc4