-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scoping issue with "no autodie" and the "system" sub #69
Comments
The error received is:
|
Skip uninstalling subs that we never installed. This makes sure we don't try to reinstall nonexisting subs later when exiting the 'no autodie' scope. Bug: Dual-Life#69 Bug-Debian: https://bugs.debian.org/798096
Hi, please see the pull request I just linked. I'm not quite sure if it's correct but it seems to work. |
Taking that back: the change only works on the 'main' package so it still needs some more work :) |
Don't queue nonexisting subs for reinstalling later when exiting the 'no autodie' scope. FIXME: if the original sub 'can be undef for "CORE::" subs', does this break for those? Is that the case when $symbol =~ /::/, as guarded for on L566? Bug: Dual-Life#69 Bug-Debian: https://bugs.debian.org/798096
Hi, ntyni@c1b4fc4 is my next try and passes all tests, but I'm not sure about this: FIXME: if the original sub 'can be undef for "CORE::" subs', does this break for those? Is that the case when $symbol =~ /::/, as guarded on L566? Help/comments would be welcome. |
Fixed by the merge of c1b4fc4 |
Don't queue nonexisting subs for reinstalling later when exiting the 'no autodie' scope. FIXME: if the original sub 'can be undef for "CORE::" subs', does this break for those? Is that the case when $symbol =~ /::/, as guarded for on L566? Bug: Dual-Life/autodie#69 Bug-Debian: https://bugs.debian.org/798096 Origin: upstream, Dual-Life/autodie@c1b4fc4 Patch-Name: fixes/autodie-scope.diff
Don't queue nonexisting subs for reinstalling later when exiting the 'no autodie' scope. FIXME: if the original sub 'can be undef for "CORE::" subs', does this break for those? Is that the case when $symbol =~ /::/, as guarded for on L566? Bug: Dual-Life/autodie#69 Bug-Debian: https://bugs.debian.org/798096 Origin: upstream, Dual-Life/autodie@c1b4fc4 Patch-Name: fixes/autodie-scope.diff
Hi,
We saw a report in Debian (https://bugs.debian.org/798096), where autodie broke valid code.
The code can basically be reduced to:
A couple items to note:
The text was updated successfully, but these errors were encountered: