change file name format #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjfanning Is this ready or does it need more work? |
I was going to get this looked at after merging the sha512 change (they will conflict a bit) - but you're welcome to comment on the changes as they are. |
mdedetrich
reviewed
Jul 2, 2023
| @@ -26,7 +27,8 @@ private[sourcedist] object SourceDistGenerate { | |||
| ignoreList.addPatterns(customIgnorePatterns) | |||
| val files = getIncludedFiles(baseDir, ignoreList) | |||
|
|
|||
| val baseFileName = s"$prefix-src-$version" | |||
| val versionString = if (incubating) s"$version-incubating" else version | |||
There was a problem hiding this comment.
Extremely minor nit, but the variable name versionString here is slightly misleading because it also contains incubating (which has nothing to do with version).
mdedetrich
approved these changes
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #23
sourceDistNameand remove the 'incubating' but probably add 'apache'sourceDistIncubating := true