Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StackOverflowError DuplexTcpClientPipelineFactory.peerWith #49

Closed
garyfeltham opened this issue Oct 21, 2015 · 4 comments
Closed

StackOverflowError DuplexTcpClientPipelineFactory.peerWith #49

garyfeltham opened this issue Oct 21, 2015 · 4 comments
Assignees
@pjklauser
Labels
bug

Comments

@garyfeltham
Copy link 

java.lang.StackOverflowError
    at com.googlecode.protobuf.pro.duplex.client.DuplexTcpClientPipelineFactory.peerWith(DuplexTcpClientPipelineFactory.java:143)
    at com.googlecode.protobuf.pro.duplex.client.DuplexTcpClientPipelineFactory.peerWith(DuplexTcpClientPipelineFactory.java:143)```

Fix is

return peerWith(host,  port, null, null);
@pjklauser pjklauser self-assigned this Oct 21, 2015
@pjklauser pjklauser added the bug label Oct 21, 2015
pjklauser added a commit that referenced this issue Oct 21, 2015
@pjklauser
#49: fix stackoverflow.
9267982
@pjklauser
Copy link
Owner

thanks for finding this embarrassing bug:)

@garyfeltham
Copy link
Author

No worries, just running some testing and realised I introduced a bug should really be
return peerWith(host, port, bootstrap, null);

:)

pjklauser added a commit that referenced this issue Oct 24, 2015
@pjklauser
#49: missing parameter.
97ead35
@pjklauser
Copy link
Owner

well spotted. i corrected it now. Will be released in the next minor version.

@pjklauser
Copy link
Owner

released in 3.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjklauser pjklauser

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjklauser @garyfeltham