Added ConvertMetresToLengthUnits() Method #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th enum to LengthUnit, to be more clear. Re-wired some UI.
|
Sorry, I think I should have split up my commits into more bite-sized chunks.. I'll try to do that next time. |
|
I don;t think this one fits with the direction I was going and has a number of conflicting files. If you want to refresh your fork and justg add your ConvertMetresToLengthUnits method as a separate method called from ConvertLength when the input units are metres, that would work as a good model to follow for the rest of the conversions. |
…erter class, to match what is in the Enums class.
|
Sorry, took me a while to wrap my head around what was going on in Git, but I think I got it. |
|
Thank you for the work. It's appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Pierre. I made a method that converts metres to other units of length. I'm sure it's not totally perfect, but it's something we can start with, and I think it's in the spirit of what you were doing. I also renamed the Length enum to LengthUnits, which seemed to make more sense to me. If you don't like it, you're welcome to change it back. One last thing I did was to re-wire the UI work I did previously, to allow us to test the new conversion method I added.