Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement hotkeys using KGlobalAccel application tab #24

Merged
merged 6 commits into from Mar 27, 2024

Conversation

nazarewk
Copy link
Contributor

@nazarewk nazarewk commented Oct 19, 2023

fixes #18

implemented it in a slightly different manner than proposed by grouping all managed hotkeys under one application in configuration manager and having just one desktop entry with multiple actions.
Replicating "Add Command" flow (proposed in #18) resulted in terribly unreadable menu entry.

nix configurations is compatible with the master, I have simply added a new option keys.

looks like this:
Screenshot_20231019_155244
with following config
https://github.com/nazarewk-iac/nix-configs/blob/c4a5a18a0959671c0471acbd7ee46608b05b71d5/modules/profile/user/me/hm.nix#L62-L113

@pjones
Copy link
Owner

pjones commented Oct 19, 2023

This is fantastic!

Does this impact the rc2nix.rb script in any way? Should it?

@nazarewk
Copy link
Contributor Author

nazarewk commented Oct 20, 2023

To be honest this (2 days ago) is the first time I'm touching KDE so I'm taking baby steps by configuring most essential/annoying parts first. I did not take a look at rc2nix at all yet (probably never will) since I'm configuring Plasma from scratch without any prior config.
I basically got spoiled by config as a code of Sway over last 2 years and want to replicate what's possible in plasma-manager, previously used XFCE for a decade.

@toast003
Copy link
Collaborator

Did some testing and it works, although I have noticed that when you remove a hotkey from the home-manager config, it still shows up in the settings (which is not necessarily a problem, shortcuts do the same), however it stops working

@magnouvean
Copy link
Collaborator

I updated this to work on the newest plasma-manager and it works great on my end! When using overrideConfig I didn't see any hotkeys still show up in settings (I didn't test if they were there when not using overrideConfig though). I'll merge this right away. Maybe there are some minor tweaks we could do, but this is miles better than the old solution anyway, which doesn't work at all anymore as far as I know.

@magnouvean magnouvean merged commit 92b2590 into pjones:trunk Mar 27, 2024
1 check passed
@magnouvean magnouvean mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from KHotkeys to KGlobalAccel for custom command shortcuts
4 participants