Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong HSB Format #3

Closed
fabik111 opened this issue Oct 24, 2019 · 2 comments
Closed

Wrong HSB Format #3

fabik111 opened this issue Oct 24, 2019 · 2 comments

Comments

@fabik111
Copy link

I'm using this lib with HSB color format, when Brightness is set at 100% or 1.0 (according lib convention) the led color is always white (like HSL color format) instead of full color. So the method setColorHSB is in HSL color format not HSB. Check this site
@pjpmarques
Copy link
Owner

You are absolutely correct. I don't know how this happened. The routine had been adapted from here but, somehow, instead of putting HSL I've put HSB. Probably because they are similar.

pjpmarques added a commit that referenced this issue Oct 25, 2019
@pjpmarques
The routine setColorHSB() was incorrect. It implemented the HSL color…
8764e66 
… space and not the HSL one.

Refactored the routines so that it reflects the HSL space.
See [Wrong HSB Format](#3).
@pjpmarques
Copy link
Owner

Refactored the code so that HSB became HSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjpmarques @fabik111