Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to polyline #9

Merged
merged 3 commits into from Oct 11, 2020
Merged

Add support to polyline #9

merged 3 commits into from Oct 11, 2020

Conversation

allevo
Copy link
Contributor

@allevo allevo commented Oct 10, 2020 •
edited

In this PR there's the support to polyline format.
The extension chosen is input.polyline: I can change it if it is not applicable.
A new option precision is added in order to specify which precision should be used on input parsing.

Close #6

pjsier
pjsier requested changes Oct 11, 2020
View reviewed changes
Copy link
Owner

@pjsier pjsier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Made a few comments, and it looks like there are some merge conflicts with Cargo.lock, but then this should be good to go

fixtures/input.polyline Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
pjsier
pjsier requested changes Oct 11, 2020
View reviewed changes
Copy link
Owner

@pjsier pjsier left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Commented here, but for now it seems more straightforward to move the precision parsing into handle_polyline

src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@pjsier pjsier merged commit 7ae438e into pjsier:main Oct 11, 2020
@pjsier pjsier mentioned this pull request Sep 27, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjsier pjsier pjsier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for polyline input
2 participants
@allevo @pjsier