Skip to content

Commit

Permalink
Fixed #2046: ICE: Use STUN FINGERPRINT attribute when sending keepalives
Browse files Browse the repository at this point in the history
git-svn-id: https://svn.pjsip.org/repos/pjproject/trunk@5665 74dad513-b988-da41-8d7b-12977e46ad98
  • Loading branch information
sauwming committed Sep 28, 2017
1 parent eb5182d commit d063757
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions pjnath/src/pjnath/ice_session.c
Expand Up @@ -1217,10 +1217,12 @@ static void ice_keep_alive(pj_ice_sess *ice, pj_bool_t send_now)
msg_data = PJ_POOL_ZALLOC_T(tdata->pool, pj_ice_msg_data);
msg_data->transport_id = the_check->lcand->transport_id;

/* Temporarily disable FINGERPRINT. The Binding Indication
* SHOULD NOT contain any attributes.
/* RFC 5245 Section 10:
* The Binding Indication SHOULD contain the FINGERPRINT attribute
* to aid in demultiplexing, but SHOULD NOT contain any other
* attributes.
*/
saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_FALSE);
saved = pj_stun_session_use_fingerprint(comp->stun_sess, PJ_TRUE);

/* Send to session */
addr_len = pj_sockaddr_get_len(&the_check->rcand->addr);
Expand Down

0 comments on commit d063757

Please sign in to comment.