Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore/discard DNS SRV response with truncated flag set #2200

Closed
pjsipbot opened this issue May 23, 2019 · 0 comments
Closed

Ignore/discard DNS SRV response with truncated flag set #2200

pjsipbot opened this issue May 23, 2019 · 0 comments

Comments

@pjsipbot
Copy link
Collaborator

2019-05-23 14:23:00: @trengginas created the issue on trac ticket 2200

The standard stated:

DNS resolvers and recursive servers MUST support UDP, and
SHOULD support TCP, for sending (non-zone-transfer) queries.
Specifically, a DNS resolver or server that is sending a
non-zone-transfer query MUST send a UDP query first.  If the
Answer section of the response is truncated and if the
requester supports TCP, it SHOULD try the query again using
TCP.

.........
         
Truncated responses MUST NOT be saved (cached) and later
used in such a way that the fact that they are truncated is
lost.

Instead of following up with a TCP query which is unsupported, currently the library will follow up with DNS A query. Based on the recommendation above, it's better to discard the response and raise error.

Thanks to Daniel Schopf for the report.


2019-05-23 14:42:29: @trengginas changed status from new to closed


2019-05-23 14:42:29: @trengginas set owner to @trengginas


2019-05-23 14:42:29: @trengginas set resolution to fixed


2019-05-23 14:42:29: @trengginas commented

In r6000:
Close #2200: Ignore/discard DNS SRV response with truncated flag set.

@pjsipbot pjsipbot added this to the release-2.9 milestone Feb 14, 2020
qmphan pushed a commit to qmphan/pjproject that referenced this issue Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants