Fix bug when hanging up call #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trengginas
approved these changes
Mar 31, 2022
nanangizz
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of regressions caused by #2600 and #2859 when hanging up a call:
In the scenario of media transport creation still in progress,
pjsua_call_hangup()will try to end the session by callingcall_inv_end_session()even though it says in the log that itWill continue call %d hangup upon completion of media transport.One of the consequence of this regression is that it will cause assertion in Pjsua2 if
Account::onIncomingCall()is not implemented:Assertion failed: (tdata != ((void*)0)), function pjsip_inv_end_session, file ../src/pjsip-ua/sip_inv.c, line 2805.In pjsua2,
onIncomingCall()can be called fromonCreateMediaTransport(), i.e. when media transport creation is still in progress, so ending the session prematurely causes the above assertion.Avoid double BYE when pjsua_call_hangup() is called multiple times #2859 was created to prevent sending double BYE. Unfortunately, it will also cause the continuation of call hangup in the above scenario to fail as well since the second call hangup will just be ignored.