Old capture device not removed when switching video capture device #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
approved these changes
Jan 5, 2023
trengginas
approved these changes
Jan 9, 2023
sauwming
pushed a commit
that referenced
this pull request
Jul 5, 2023
dshamaev-intermedia
pushed a commit
to intermedia-net/pjproject
that referenced
this pull request
Sep 4, 2023
(cherry picked from commit 24006a7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing switching capture device, e.g: using
pjsua_call_set_vid_strm(PJSUA_CALL_VID_STRM_CHANGE_CAP_DEV), the old capture device is not disconnected from encoding stream port, so remove will receive mixed capture devices in a single window.After investigation, it turns out there is a bug in video conference that prevent it from disconnecting ports.
This PR also added more log lines and updated some log levels.
Thanks to Giorgio Alfarano for the report.