Fixed race condition between session timer and call disconnection #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #2732.
I can reproduce it on my machine with the reported scenario:
When trying to perform session refresh, A will assert in
pjsip_inv_update():inv->state < PJSIP_INV_STATE_DISCONNECTED.Note that the issue doesn't happen when A is the one hanging up the call since the session timer will be ended upon calling
pjsip_inv_end_session()here:https://github.com/pjsip/pjproject/blob/master/pjsip/src/pjsip-ua/sip_inv.c#L2925
So the proposed patch is to end the session timer upon receipt of incoming BYE.
Additionally, we can also consider to remove the assertion in
pjsip_inv_update()if state isDISCONNECTEDand return normal error instead.