Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Push Notification in iOS sample app #3913

Merged
merged 3 commits into from Apr 23, 2024
Merged

Support Push Notification in iOS sample app #3913

merged 3 commits into from Apr 23, 2024

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Apr 4, 2024

Provide an example on how to implement Push Notification using PushKit and CallKit frameworks in ipjsua sample app.

Also in this PR:
Add sample on how to call PJSIP functions from a PJLIB registered thread via timer.

@nanangizz
Copy link
Member

Is two/more incoming calls scenario handled, e.g:

  • concurrently, user may want to choose which call to answer, or
  • another incoming call in the middle of an active call.

@sauwming
Copy link
Member Author

Ah right, currently it's not handled yet.
I will add this to the implementation.

@sauwming
Copy link
Member Author

Is two/more incoming calls scenario handled, e.g:

  • concurrently, user may want to choose which call to answer, or
  • another incoming call in the middle of an active call.

Done.

Copy link
Member

@nanangizz nanangizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

Btw, the patch seems to also add sample code of how to call PJSIP functions from a PJLIB registered thread via timer, perhaps add desc about this too?

@sauwming sauwming merged commit 472bda5 into master Apr 23, 2024
36 checks passed
@sauwming sauwming deleted the ios-push branch April 23, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants