-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't delete your comments on other users posts #2
Comments
i've been able to delete my own posts on my own items |
Sorry for not being clear. This affects deleting a comment you made on a post made my someone else. The issue is down to using the 'comment.user_username' in the generation of the URL and not the property field I added to the Post representation (not stored in Redis) a few weeks back 'comment.post_author' which is needed to generate the correct URL These URLs can get a little confusing as a comments URLs are in the form: /<post_authors_username>/<post_id>/<comment_id>/['upvote', 'downvote', 'delete'] This makes sense for the actions as comments are children of posts. If you look at the URL for creating a comment: /<post_author>/<post_id>/comment It makes a little more sense. This is fixed in the 0.2dev branch (I changed the name from 'new_design'). I will leave this open until testing after platform rebuild on Friday. I will close once I know its gone for good. |
This bug is now fixed as of 0.2dev. Missed closing through commit message. Closing manually. |
This is a massive oversight in a template update. This is fixed in the new_design branch. Will not backport at the moment as new site goes live Friday. Will close issue then. Please be aware.
This does not affect deleting posts. All comments will be deleted during this operation.
The text was updated successfully, but these errors were encountered: