get rid of all module deps #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergi/go-diff is only used in one test, though having it as a module dependency is still noteworthy. That will become less of a problem once lazy module loading is widespread, but that's still at least one year away. Plus, we only used go-diff for a simple use case: to show a diff for a failed diff test. We already print the got/want text, so a diff is strictly speaking not necessary. Plus, if printing the entire text is reasonable, it's not like the diff would matter in terms of printing less text. While at it, bump the go language version from 1.13 to 1.15, since Go 1.14.x and older are no longer maintained. Fixes pkg#23.
|
LGTM in the context of rogpeppe/go-internal#131, but I'll leave to @josharian to actually review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)