This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
errors: add Debug() function #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function allows users to use "%v" formatting everywhere, and then dynamically decide whether they want to enable stack traces. If they call errors.Debug(true) then "%v" formatting will return a stack trace, otherwise it will be equivalent to "%s". Signed-off-by: Aleksa Sarai <asarai@suse.de>
|
I've also added tests which is basically a full copy of |
This is effectively a copy of format_test.go, but with all of the "%v" tests changed to be identical to "%+v" (which required changing all of the line numbers). Signed-off-by: Aleksa Sarai <asarai@suse.de>
cyphar
added a commit
to opencontainers/umoci
that referenced
this pull request
Dec 16, 2016
Include a backported version of pkg/errors#97, which adds the ability to dynamically generate stacks if a user of "%v" formatting calls errors.Debug(true). Signed-off-by: Aleksa Sarai <asarai@suse.com>
|
/cc @davecheney |
|
Closed because #96 is closed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function allows users to use "%v" formatting everywhere, and then
dynamically decide whether they want to enable stack traces. If they
call errors.Debug(true) then "%v" formatting will return a stack trace,
otherwise it will be equivalent to "%s".
Fixes: #96
Signed-off-by: Aleksa Sarai asarai@suse.de