Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should RequiredUseDefaults warn people when software needs (X || wayland)? #667

Open
eli-schwartz opened this issue Feb 20, 2024 · 2 comments
Labels

Comments

@eli-schwartz
Copy link

The idea here is that pkgcheck wants either one or the other to be default enabled in IUSE.

From IRC:

16:32 <colores> What does this error (https://bpa.st/2YZQ) mean exactly? I assume, pkgcheck wants me to add +X or +wayland, but why?.
16:33 <ztrawhcse> colores: it is in man pkgcheck
16:33 <ztrawhcse> basically your IUSE default values are impossible for users to use by default
16:34 <ztrawhcse> however it is possible that for X / wayland specifically, the check could be relaxed
16:34 <ztrawhcse> given they are global flags one is likely to have set globally in the profile
16:34 <ztrawhcse> maybe arthurzam has some thoughts about this
16:40 <colores> Thanks, makes sense!
14:47 <@arthurzam> ztrawhcse: I would be thankful if you could open an issue on github.com/pkgcore/pkgcheck, where I'll ping QA team for opening the discussion on that. I can see from where you come, but I'm unsure all profiles define default X or wayland, and those cases even hit hard on AT process.
14:47 <@arthurzam> So input from QA team will be best

Are there exceptions to wanting REQUIRED_USE to have a valid default resolution, if it is "most likely" that the user's selected profile will toggle one independent of IUSE defaults?

@arthurzam
Copy link
Member

The pastebin in question contains:

$ pkgcheck scan
dev-python/pyclip
  RequiredUseDefaults: version 0.7.0-r1: profile: 'default/linux/amd64/17.0/musl' (84 total) failed REQUIRED_USE: ( wayland || X )

@thesamesam
Copy link
Member

This is probably a case for annotations where we can suppress it per-package (maybe list the profiles we want to ignore it on).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants