Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no_vdb restriction if --preload-vdb-state given #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4eetah
Copy link
Contributor

@4eetah 4eetah commented Jul 31, 2016

Fixes #51

@codecov-io
Copy link

codecov-io commented Jul 31, 2016

Current coverage is 55.23% (diff: 0.00%)

Merging #218 into master will decrease coverage by <.01%

@@             master       #218   diff @@
==========================================
  Files           148        148          
  Lines         20908      20910     +2   
  Methods           0          0          
  Messages          0          0          
  Branches       5252       5253     +1   
==========================================
  Hits          11550      11550          
- Misses         8638       8640     +2   
  Partials        720        720          

Powered by Codecov. Last update 5994b8a...716aa48

@4eetah
Copy link
Contributor Author

4eetah commented Jul 31, 2016

This is actually a quick fix which implicitly imposes --noreplace option.
Currently, things work in a way that if no --noreplace option is given the additional restriction is added (_vdb_restrict) so that resolver doesn't look through livefs_vdb and virtual packages.
I guess the more properly would be to still allow for rebuild of already installed pkgs even though --preload-vdb-state is given, which seems inevitably trigger a lot more changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants