Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmerge: handle permission failures in a more friendly way #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

4eetah
Copy link
Contributor

@4eetah 4eetah commented Jul 31, 2016

Issue #154

@codecov-io
Copy link

codecov-io commented Jul 31, 2016

Current coverage is 55.22% (diff: 18.18%)

Merging #220 into master will decrease coverage by 0.02%

@@             master       #220   diff @@
==========================================
  Files           148        148          
  Lines         20908      20918    +10   
  Methods           0          0          
  Messages          0          0          
  Branches       5252       5255     +3   
==========================================
+ Hits          11550      11551     +1   
- Misses         8638       8647     +9   
  Partials        720        720          

Powered by Codecov. Last update 5994b8a...d93accc

@4eetah
Copy link
Contributor Author

4eetah commented Jul 31, 2016

I don't really know if you would like "suppress_exceptions = False" for all triggers. Another way to propagate such exceptions is checking for errno.EACCES in merge engine and having suppress_exceptions enabled:

345                     except Exception as e:
346                         if not trigger.suppress_exceptions:
347                             raise
348
349                         handle = stringio.text_writable()
350                         traceback.print_exc(file=handle)
351
352                         self.observer.warn(
353                             "unhandled exception caught and suppressed:\n%s", handle.getvalue())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants