Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebd: update EAPI 8 --disable-static rule per PMS update #330

Merged
merged 1 commit into from Sep 27, 2021
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Sep 27, 2021

Update the EAPI 8 --disable-static to be emitted when either
--disable-static or --enable-static occurs in configure --help output.
This is necessary to handle libtool packages correctly, and this is how
it was initially implemented in Portage. PMS is being updated to match.

Bug: https://bugs.gentoo.org/814368

Update the EAPI 8 --disable-static to be emitted when either
--disable-static or --enable-static occurs in configure --help output.
This is necessary to handle libtool packages correctly, and this is how
it was initially implemented in Portage.  PMS is being updated to match.

Bug: https://bugs.gentoo.org/814368
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #330 (6c57606) into master (f5fa26b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   53.58%   53.58%           
=======================================
  Files         141      141           
  Lines       21804    21804           
  Branches     4594     4594           
=======================================
  Hits        11684    11684           
  Misses       9470     9470           
  Partials      650      650           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5fa26b...6c57606. Read the comment docs.

Copy link
Contributor

@ulm ulm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgorny mgorny merged commit 6c57606 into master Sep 27, 2021
@mgorny mgorny deleted the eapi8-static branch September 27, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants