Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename @ECLASS-VARIABLE to @ECLASS_VARIABLE #336

Closed
wants to merge 3 commits into from
Closed

Rename @ECLASS-VARIABLE to @ECLASS_VARIABLE #336

wants to merge 3 commits into from

Conversation

ulm
Copy link
Contributor

@ulm ulm commented Mar 17, 2022

No description provided.

ulm added 2 commits March 17, 2022 11:46
@ulm
ebuild.eclass: Rename @ECLASS-VARIABLE to @ECLASS_VARIABLE
defe928 
Still accept the version with a hyphen for backwards compatibility.

Bug: https://bugs.gentoo.org/835396
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
@ulm
ebuild.test_eclass: Rename @ECLASS-VARIABLE to @ECLASS_VARIABLE
b167baf 
Bug: https://bugs.gentoo.org/835396
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
@codecov
Copy link

codecov bot commented Mar 17, 2022 •
edited

Codecov Report

Merging #336 (4497b90) into master (4452cd1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   53.59%   53.61%   +0.01%     
==========================================
  Files         141      141              
  Lines       21806    21813       +7     
  Branches     5158     5159       +1     
==========================================
+ Hits        11687    11694       +7     
- Misses       9457     9459       +2     
+ Partials      662      660       -2
Impacted Files Coverage Δ
src/pkgcore/ebuild/eclass.py 59.39% <100.00%> (+0.73%) ⬆️
src/pkgcore/vdb/ondisk.py 30.66% <0.00%> (ø)
src/pkgcore/scripts/pmerge.py 17.18% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4452cd1...4497b90. Read the comment docs.

@thesamesam
Copy link
Member

conceptual ack

@ulm
ebuild.test_eclass: Also test old @ECLASS-VARIABLE syntax
4497b90 
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
mgorny
mgorny approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Maybe I'll experiment with trying to simplify the code later.

@mgorny mgorny closed this in 5d36a98 Mar 18, 2022
@ulm ulm deleted the eclass_variable branch March 18, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ulm @thesamesam @mgorny