-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkgdev tatt: new tool for package testing #109
Conversation
Codecov ReportBase: 90.12% // Head: 80.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 90.12% 80.56% -9.57%
==========================================
Files 13 14 +1
Lines 1205 1348 +143
Branches 281 319 +38
==========================================
Hits 1086 1086
- Misses 93 235 +142
- Partials 26 27 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feel free to ignore- this is just a drive by reading of the code w/ some comments.
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU General Public License for more details. | ||
#} | ||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must this be bash? My rough thought here was a python script that had the argument list just json blobbed into it, and then it feeds that back to the pkgdev_tatt code.
Pardon if that's assinine, I'm just going through the code and learning. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My idea is to create a good replacement for tatt
tool, and not a full wrapper. Folks can use other jinja templates (--template-file
) to create a whole other possibilities. For a more sophisticated tool, like a testing server, maybe this more inline with tattoo.
a2059cd
to
186c698
Compare
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
This depends on pkgcore/pkgcore#380. If you want to test this PR, please apply both PRs to relevant projects.
This is a new tool, replacing
tatt
, and uses the new fast REQUIRED_USE solver. This tool has a lot of command line options, but my idea was that most are filled inpkgdev.conf
, and then the invocations should be simple.For example:
And then you can call:
pkgdev tatt -b 886097
TODO
docs
to each cmdline arg