Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords reordering mangler #47

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

arthurzam
Copy link
Member

Automatically reorder keywords to be sorted with OS and arch.
Based on nattka's code at nattka/keyword.py

Resolves: #46

Automatically reorder keywords to be sorted with OS and arch.
Based on nattka's code at nattka/keyword.py

Resolves: pkgcore#46
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #47 (93a57ed) into main (e289c4a) will increase coverage by 0.21%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   85.42%   85.63%   +0.21%     
==========================================
  Files          12       12              
  Lines        1022     1037      +15     
  Branches      198      229      +31     
==========================================
+ Hits          873      888      +15     
  Misses        121      121              
  Partials       28       28              
Impacted Files Coverage Δ
src/pkgdev/mangle.py 99.00% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e289c4a...93a57ed. Read the comment docs.

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@thesamesam
Copy link
Member

Only suggestion is to make use of this in nattka, possibly.

@arthurzam arthurzam merged commit 00813f7 into pkgcore:main Mar 25, 2022
@arthurzam arthurzam deleted the keyword-mangler branch March 25, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commit: ensure alphabetical ordering of KEYWORDS when new keywords are added
2 participants