Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask: improve parsing of package.mask file #87

Merged
merged 4 commits into from
Sep 11, 2022

Conversation

arthurzam
Copy link
Member

No description provided.

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Base: 94.56% // Head: 94.90% // Increases project coverage by +0.34% 🎉

Coverage data is based on head (dc9ad00) compared to base (98cfd69).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
+ Coverage   94.56%   94.90%   +0.34%     
==========================================
  Files          13       13              
  Lines        1177     1178       +1     
  Branches      297      298       +1     
==========================================
+ Hits         1113     1118       +5     
+ Misses         36       34       -2     
+ Partials       28       26       -2     
Impacted Files Coverage Δ
src/pkgdev/scripts/pkgdev_mask.py 97.46% <100.00%> (+2.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

If the header of mask had a break, which looked like `#`, it would fail
to parse, which is somewhat wrong. So add it as exception.

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
@arthurzam arthurzam merged commit dc9ad00 into pkgcore:main Sep 11, 2022
@arthurzam arthurzam deleted the small-fix branch September 11, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant