Sync cache #60
Merged
Sync cache #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7732868666
💛 - Coveralls |
mxcl
force-pushed
the
sync-cache
branch
4 times, most recently
from
3ab08b1
to
965b5aa
Compare
mxcl
force-pushed
the
sync-cache
branch
2 times, most recently
from
606167a
to
75ae91d
Compare
We had to vendor the deno sqlite3 library as it had no other direct way to allow us to configure the path to the sqlite library at runtime. To accomplish this we had to modify the sources somewhat also :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the sqlite3 deno library downloads its own sqlite. Instead we should:
However there isn’t a way to get it to do that yet. See denodrivers/sqlite3#119
Possibly we could vendor and modify.
Also the cache should “failsafe” and fall back on the pantry in the case of issues with FFI or sqlite or our code.