Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restic #4098

Merged
merged 1 commit into from Nov 18, 2023
Merged

add restic #4098

merged 1 commit into from Nov 18, 2023

Conversation

MarkusZoppelt
Copy link
Contributor

@MarkusZoppelt MarkusZoppelt commented Nov 17, 2023

Adds pkg for restic by @MichaelEischer

@mxcl
Copy link
Member

mxcl commented Nov 17, 2023

pkg has a homepage so we tend to prefer to use that: restic.net

You mind renaming? Thanks

go.dev: ^1.20

test:
restic version

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not run go test ./...?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the source isn't available in the test node. if you wanted to run source tests, you'd do that in the build node. the test node is for ensuring the resulting binary(ies) work properly.

Copy link
Member

@mxcl mxcl Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that I really should make the sources and build dirs available since this is a common thing we want to do. Only reason we do not is due to github actions needing these dirs to be artefacts so that we can test on different machines.

And well, that means everything would need to be rebuilt since (for linux builds at least) we use different operating systems for the tests

We could perhaps have a “test step in the build step” sort of thing. lol

projects/github.com/restic/restic/package.yml Outdated Show resolved Hide resolved
@MarkusZoppelt
Copy link
Contributor Author

pkg has a homepage so we tend to prefer to use that: restic.net

You mind renaming? Thanks

Done!

@MarkusZoppelt MarkusZoppelt changed the title add(restic) add restic Nov 18, 2023
@mxcl mxcl merged commit 1d3a6c2 into pkgxdev:main Nov 18, 2023
19 checks passed
@MarkusZoppelt MarkusZoppelt deleted the restic branch November 18, 2023 12:38
@mxcl
Copy link
Member

mxcl commented Nov 18, 2023

MarkusZoppelt added a commit to MarkusZoppelt/restic that referenced this pull request Nov 19, 2023
MichaelEischer pushed a commit to MarkusZoppelt/restic that referenced this pull request Dec 24, 2023
MichaelEischer pushed a commit to restic/restic that referenced this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants