New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restic
#4098
add restic
#4098
Conversation
0ef429c
to
66b2242
Compare
pkg has a homepage so we tend to prefer to use that: restic.net You mind renaming? Thanks |
go.dev: ^1.20 | ||
|
||
test: | ||
restic version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not run go test ./...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the source isn't available in the test
node. if you wanted to run source tests, you'd do that in the build
node. the test
node is for ensuring the resulting binary(ies) work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that I really should make the sources and build dirs available since this is a common thing we want to do. Only reason we do not is due to github actions needing these dirs to be artefacts so that we can test on different machines.
And well, that means everything would need to be rebuilt since (for linux builds at least) we use different operating systems for the tests
We could perhaps have a “test step in the build step” sort of thing. lol
66b2242
to
cff13c4
Compare
Done! |
PR in pkgx pantry: pkgxdev/pantry#4098 restic pkg: https://pkgx.dev/pkgs/restic.net/restic/
PR in pkgx pantry: pkgxdev/pantry#4098 restic pkg: https://pkgx.dev/pkgs/restic.net/restic/
PR in pkgx pantry: pkgxdev/pantry#4098 restic pkg: https://pkgx.dev/pkgs/restic.net/restic/
Adds pkg for restic by @MichaelEischer