Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DENO_INSTALL_ROOT to make deno install to ~/.local #5752

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

felipecrs
Copy link
Contributor

@felipecrs
Copy link
Contributor Author

PS: this is doing the same as cargo:

- export CARGO_INSTALL_ROOT=$HOME/.local

@jhheider jhheider requested a review from mxcl April 1, 2024 18:29
@jhheider
Copy link
Contributor

jhheider commented Apr 1, 2024

@mxcl what do you think about this one? seems like a step back to use runtime environment (thereby requiring pkgx) over having the binary work as intended even if invoked directly?

@felipecrs
Copy link
Contributor Author

PS: I have no strong opinion, except by keeping consistency (meaning if we decide that patching is better, we should do it for cargo as well).

@jhheider
Copy link
Contributor

jhheider commented Apr 1, 2024

agree re: consistency. strongly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants