fix: using memory proportional to download size #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It is quite unlucky but I believe this is the only non-ffi solution to this problem |
mxcl
approved these changes
Feb 5, 2023
|
Thank you so much @lino-levan! It would have taken us much longer to debug this. |
|
Sorry I didn't merge this sooner, it didn’t hit my notifications radar for some reason. Pushing out a point release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about waiting so long to do this easy PR. I have been relatively busy this week and technically I am still busy but I felt bad about promising to do this and not following through.
Theoretically closes #338