Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .terraform-version file format for dev command #832

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add support for .terraform-version file format for dev command #832

merged 1 commit into from
Oct 25, 2023

Conversation

kishaningithub
Copy link
Contributor

Fixes #831

@mxcl
Copy link
Member

mxcl commented Oct 25, 2023

Thank you @kishaningithub for your excellent feedback and now your contribution also.

@mxcl mxcl merged commit e39255b into pkgxdev:main Oct 25, 2023
5 checks passed
@mxcl
Copy link
Member

mxcl commented Oct 25, 2023

Will publish 1.0.5 by EoW

@kishaningithub kishaningithub deleted the add-terraform-version-support branch October 25, 2023 14:11
@kishaningithub
Copy link
Contributor Author

By creating this PR i also learnt that deno can publish a self contained binary and can also cross compile. Previously i was of the opinion that only languages like golang can do something like that.

@mxcl
Copy link
Member

mxcl commented Oct 25, 2023

run deno task install if you want /usr/local/bin/pkgx with this change in the meantime.

@kishaningithub kishaningithub restored the add-terraform-version-support branch October 27, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxcl mxcl mxcl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for .terraform-version in dev cli
2 participants
@kishaningithub @mxcl