Skip to content
Validate Avram Schemas

Reformat comments #171

Sign in to view logs

Reformat comments

Reformat comments #171

Triggered via push May 17, 2024 12:06
@pkiralypkiraly
pushed e514a85
main
Status Success
Total duration 19s
Artifacts –

avram.yml

on: push
build
8s
build
Fit to window
Zoom out
Zoom in

Annotations

122 warnings and 6 notices
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/AlephseqLine.java#L97
Value `content` is always 'null'
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L517
Value `_subfieldMatches` is always 'null'
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarclineLine.java#L80
Value `content` is always 'null'
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/unimarc/UnimarcSchemaReader.java#L375
Value `positionEndObject` is always 'null'
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarcMakerLine.java#L85
Value `content` is always 'null'
Constant values: src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java#L332
Value `value` is always 'null'
Redundant 'Collection.addAll()' call: src/main/java/de/gwdg/metadataqa/marc/Utils.java#L43
'addAll()' call can be replaced with parametrized constructor call
Constant values: src/main/java/de/gwdg/metadataqa/marc/MarcFactory.java#L339
Condition `picadf != null` is always `true` when reached
Constant values: src/main/java/de/gwdg/metadataqa/marc/cli/parameters/CommonParameters.java#L386
Condition `this.defaultRecordType == null` is always `false`
Constant values: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java#L318
Condition `!versionSpecificSubfieldsMap.isEmpty()` is always `true`
Constant values: src/main/java/de/gwdg/metadataqa/marc/utils/MarcCacheWrapper.java#L40
Condition `path != null` is always `true`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/cli/utils/ignorablerecords/CriteriumPica.java#L63
Dereference of `codes` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPathParser.java#L83
The call to 'substring' always fails as an argument is out of bounds
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java#L329
Condition `value instanceof List` is redundant and can be replaced with a null check
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java#L49
Method invocation `getLabel` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java#L21
Method invocation `getValue` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/pica/crosswalk/PicaMarcCrosswalkReader.java#L46
Argument `PicaMarcCrosswalkReader.class.getResourceAsStream("/pica/pica-marc.tsv")` might be null
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/analysis/functional/UnimarcFrbrFunctionLister.java#L47
Method invocation `getFile` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/dao/Control006.java#L121
Argument `actual` might be null
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/EncodedValueFileReader.java#L50
Argument `classLoader.getResourceAsStream(fileName)` might be null
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java#L77
Method invocation `getValue` may produce `NullPointerException`
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/Position.java#L14
Variable is already assigned to this value
Nullability and data flow problems: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MarcJsonToSolr.java#L43
Variable is already assigned to this value
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/analysis/serial/Marc21Serial.java#L108
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/dao/record/MarcRecord.java#L148
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/marcreader/MarclineReader.java#L119
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L169
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/analysis/serial/Marc21Serial.java#L96
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L172
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L167
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/analysis/serial/Marc21Serial.java#L120
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/marcreader/MarcMakerReader.java#L120
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L168
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L170
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaSchemaReader.java#L174
`if` statement has empty body
Statement with empty body: src/main/java/de/gwdg/metadataqa/marc/utils/marcreader/AlephseqMarcReader.java#L151
`if` statement has empty body
Result of method call ignored: src/main/java/de/gwdg/metadataqa/marc/definition/controlpositions/tag007/Tag007soundRecording00.java#L39
Result of `Arrays.asList()` is ignored
Inner class may be 'static': src/main/java/de/gwdg/metadataqa/marc/analysis/DataElementCounter.java#L83
Inner class `DataElement` may be 'static'
Integer multiplication or shift implicitly cast to 'long': src/main/java/de/gwdg/metadataqa/marc/utils/BasicStatistics.java#L45
entry.getKey() \* entry.getValue(): integer multiplication implicitly cast to long
Malformed format string: src/main/java/de/gwdg/metadataqa/marc/utils/CodeGenerator.java#L21
Too many arguments for format string (found: 1, expected: 0)
Malformed format string: src/main/java/de/gwdg/metadataqa/marc/utils/CodeGenerator.java#L35
Too many arguments for format string (found: 1, expected: 0)
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/cli/DataElements.java#L42
Contents of collection `elementCardinality` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/cli/SerialScore.java#L55
Contents of collection `histogram` are queried, but never updated
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/model/kos/KosRegistry.java#L9
Contents of collection `entries` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/cli/DataElements.java#L43
Contents of collection `elementFrequency` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/cli/NetworkAnalysis.java#L37
Contents of collection `orphans` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L474
Contents of collection `subfields` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/definition/TagDefinitionLoader.java#L35
Contents of collection `commonCache` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/cli/DataElements.java#L41
Contents of collection `packageCounter` are updated, but never queried
Mismatched query and update of collection: src/main/java/de/gwdg/metadataqa/marc/definition/general/parser/LinkageParser.java#L51
Contents of collection `invalidChars` are updated, but never queried
Overwritten Map, Set, or array element: src/main/java/de/gwdg/metadataqa/marc/analysis/thompsontraill/Marc21ThompsonTraillAnalysis.java#L393
Duplicate Map key
Overwritten Map, Set, or array element: src/main/java/de/gwdg/metadataqa/marc/analysis/thompsontraill/Marc21ThompsonTraillAnalysis.java#L394
Duplicate Map key
Pointless arithmetic expression: src/main/java/de/gwdg/metadataqa/marc/definition/general/validator/ISBNValidator.java#L171
`digit * 1` can be replaced with 'digit'
Duplicate branch in alternation: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L96
Duplicate branch in alternation
Duplicate branch in alternation: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L129
Duplicate branch in alternation
Consecutive spaces: src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarcMakerLine.java#L103
2 consecutive spaces in RegExp
Single character alternation: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L79
Single character alternation in RegExp
Single character alternation: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L79
Single character alternation in RegExp
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L156
Unnecessary non-capturing group `(?:\\{(.+?)\\})`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L59
Unnecessary non-capturing group `(?:[_a-z0-9][_a-z0-9]{0,1})`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L32
Unnecessary non-capturing group `(?:(?:(?:\\d+|#)\\-(?:\\d+|#))|(?:\\d+|#))`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L139
Unnecessary non-capturing group `(?:\\\\(?:(?<=\\\\)[!=~\\?]|[^!=~\\?])+)`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L93
Unnecessary non-capturing group `(?:missingValuemissingValue(?:missingValue|missingValue)?missingValuemissingValue)`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L39
Unnecessary non-capturing group `(?:(?:(?<start>\\d+|#)\\-(?<end>\\d+|#))|(?<single>\\d+|#))`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L25
Unnecessary non-capturing group `(?:[0-9\\.]{3}|LDR|LEADER)`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L106
Unnecessary non-capturing group `(?:[0-9a-z]\\-[0-9a-z])`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L39
Unnecessary non-capturing group `(?:(?<start>\\d+|#)\\-(?<end>\\d+|#))`
Unnecessary non-capturing group: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L32
Unnecessary non-capturing group `(?:(?:\\d+|#)\\-(?:\\d+|#))`
Sorted collection with non-comparable elements: src/main/java/de/gwdg/metadataqa/marc/cli/ValidatorCli.java#L681
Construction of sorted collection with non-comparable elements
String concatenation as argument to 'StringBuilder.append()' call: src/main/java/de/gwdg/metadataqa/marc/model/validation/ValidationErrorFormatter.java#L29
String concatenation as argument to `StringBuffer.append()` call
String concatenation as argument to 'StringBuilder.append()' call: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaDataField.java#L40
String concatenation as argument to `StringBuilder.append()` call
String concatenation as argument to 'StringBuilder.append()' call: src/main/java/de/gwdg/metadataqa/marc/utils/pica/PicaDataField.java#L49
String concatenation as argument to `StringBuilder.append()` call
Suspicious 'Collection.toArray()' call: src/main/java/de/gwdg/metadataqa/marc/CsvUtils.java#L79
Array of type 'java.lang.Object\[\]' expected, 'java.lang.String\[\]' found
'Collection.toArray()' call style: src/main/java/de/gwdg/metadataqa/marc/CsvUtils.java#L71
Call to `toArray()` with pre-sized array argument 'new String\[strings.size()\]'
'Collection.toArray()' call style: src/main/java/de/gwdg/metadataqa/marc/CsvUtils.java#L57
Call to `toArray()` with pre-sized array argument 'new String\[strings.size()\]'
'Collection.toArray()' call style: src/main/java/de/gwdg/metadataqa/marc/CsvUtils.java#L79
Call to `toArray()` with pre-sized array argument 'new String\[quoted.size()\]'
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPath.java#L14
Variable `occurrence` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/CompilanceLevel.java#L12
Variable `label` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPath.java#L13
Variable `xtag` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/PicaNormalizedReader.java#L58
Variable `marc4jRecord` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/OccurrenceRange.java#L4
Variable `unitLength` initializer `0` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPath.java#L12
Variable `tag` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/analysis/contextual/authority/Marc21AuthorityAnalyzer.java#L65
Variable `organization` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/model/kos/KosType.java#L47
Variable `score` initializer `0` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/model/kos/KosType.java#L50
Variable `url` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/general/validator/ISBNValidator.java#L41
Variable `message` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/BLClassificationAnalysis.java#L36
Variable `classifier` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/PairGenerator.java#L29
Variable `asBase36` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/xml/PicaXmlParser.java#L50
Variable `reader` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToHtml.java#L91
Variable `tag` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/MarcCacheWrapper.java#L50
Variable `path` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/FRBRFunction.java#L21
Variable `parent` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/xml/PicaXmlHandler.java#L150
The value `"n/a"` assigned to `prevTag` is never used
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/QAMarcReaderFactory.java#L173
Variable `reader` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToMarkdown.java#L25
Variable `tag` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToMarkdown.java#L24
Variable `getInstance` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/analysis/contextual/classification/PicaClassificationAnalyzer.java#L23
Variable `picaVocabularyManager` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/xml/PicaXmlHandler.java#L75
Variable `factory` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPath.java#L15
Variable `subfields` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java#L325
Variable `list` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/parameters/FormatterParameters.java#L22
Variable `withId` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L394
Variable `pos` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToHtml.java#L90
Variable `getInstance` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/MarcCacheWrapper.java#L64
Variable `suffix` initializer `""` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/RecordIterator.java#L53
Variable `status` initializer `"waits"` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java#L55
Variable `exportSelfDescriptiveCodes` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/general/validator/ISSNValidator.java#L36
Variable `message` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/Completeness.java#L408
Variable `histogram` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/Position.java#L11
Variable `isNumeric` initializer `true` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L198
Variable `field` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/TagDefinitionLoader.java#L51
Variable `getInstance` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/Range.java#L14
Variable `validRange` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/keygenerator/PositionalControlFieldKeyGenerator.java#L10
Variable `isLeader` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/TagDefinitionLoader.java#L50
Variable `dataFieldDefinition` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java#L54
Variable `exportSubfieldCodes` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/xml/PicaXmlParser.java#L14
Variable `handler` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/cli/utils/ignorablerecords/CriteriumPica.java#L57
Variable `passed` initializer `false` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPathParser.java#L78
Variable `m` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/QAMarcReaderFactory.java#L142
Variable `reader` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/model/kos/KosType.java#L48
Variable `parent` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/SubfieldParser.java#L13
Variable `j` initializer `0` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/utils/pica/reader/model/PicaLine.java#L126
Variable `parts` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/CompilanceLevel.java#L13
Variable `abbreviation` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/definition/FRBRFunction.java#L22
Variable `label` initializer `null` is redundant
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/analysis/contextual/authority/Marc21AuthorityAnalyzer.java#L70
The value `content.get("organization")` assigned to `organization` is never used
Unused assignment: src/main/java/de/gwdg/metadataqa/marc/model/kos/KosType.java#L49
Variable `label` initializer `null` is redundant
Bulk operation can be used instead of iteration: src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java#L424
Iteration can be replaced with bulk 'Map.putAll()' call
Bulk operation can be used instead of iteration: src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java#L438
Iteration can be replaced with bulk 'Map.putAll()' call