issue #142: calculating PICA completeness

pkiraly · Jun 20, 2022 · 50d0470 · 50d0470
1 parent 9c877b7
commit 50d0470
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 3 deletions.
diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/Completeness.java b/src/main/java/de/gwdg/metadataqa/marc/cli/Completeness.java
@@ -224,7 +224,7 @@ private String getPackageName(DataField field) {
       if (packageNameCache.containsKey(field.getDefinition()))
         packageName = packageNameCache.get(field.getDefinition());
       else {
-        packageName = Utils.extractPackageName(field);
+        packageName = plugin.getPackageName(field);
         if (StringUtils.isBlank(packageName)) {
           logger.warning(String.format("%s has no package. /%s", field, field.getDefinition().getClass()));
           packageName = TagCategory.other.getPackageName();

diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/CompletenessPlugin.java b/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/CompletenessPlugin.java
@@ -1,9 +1,11 @@
 package de.gwdg.metadataqa.marc.cli.plugin;
 
+import de.gwdg.metadataqa.marc.dao.DataField;
 import de.gwdg.metadataqa.marc.dao.MarcRecord;
 import de.gwdg.metadataqa.marc.utils.TagHierarchy;
 
 public interface CompletenessPlugin {
   String getDocumentType(MarcRecord marcRecord);
   TagHierarchy getTagHierarchy(String path);
+  String getPackageName(DataField field);
 }
diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/Marc21CompletenessPlugin.java b/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/Marc21CompletenessPlugin.java
@@ -1,6 +1,8 @@
 package de.gwdg.metadataqa.marc.cli.plugin;
 
+import de.gwdg.metadataqa.marc.Utils;
 import de.gwdg.metadataqa.marc.cli.parameters.CompletenessParameters;
+import de.gwdg.metadataqa.marc.dao.DataField;
 import de.gwdg.metadataqa.marc.dao.MarcRecord;
 import de.gwdg.metadataqa.marc.utils.TagHierarchy;
 
@@ -22,4 +24,9 @@ public String getDocumentType(MarcRecord marcRecord) {
   public TagHierarchy getTagHierarchy(String path) {
     return TagHierarchy.createFromPath(path, parameters.getMarcVersion());
   }
+
+  @Override
+  public String getPackageName(DataField field) {
+    return Utils.extractPackageName(field);
+  }
 }
diff --git a/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/PicaCompletenessPlugin.java b/src/main/java/de/gwdg/metadataqa/marc/cli/plugin/PicaCompletenessPlugin.java
@@ -2,6 +2,7 @@
 
 import de.gwdg.metadataqa.marc.Utils;
 import de.gwdg.metadataqa.marc.cli.parameters.CompletenessParameters;
+import de.gwdg.metadataqa.marc.dao.DataField;
 import de.gwdg.metadataqa.marc.dao.MarcRecord;
 import de.gwdg.metadataqa.marc.definition.structure.SubfieldDefinition;
 import de.gwdg.metadataqa.marc.definition.tags.TagCategory;
@@ -63,7 +64,7 @@ public TagHierarchy getTagHierarchy(String rawpath) {
     PicaFieldDefinition field = picaSchema.get(path.getField());
     TagCategory category = TagCategory.other;
     if (field != null) {
-      category = TagCategory.pica;
+      category = getTagCategory(field);
       fieldLabel = field.getLabel();
       if (!path.getSubfield().equals("")){
         SubfieldDefinition subfield = field.getSubfield(path.getSubfield());
@@ -74,6 +75,24 @@ public TagHierarchy getTagHierarchy(String rawpath) {
     return new TagHierarchy(category, fieldLabel, subfieldLabel);
   }
 
+  @Override
+  public String getPackageName(DataField field) {
+    if (field.getDefinition() != null) {
+      return getTagCategory((PicaFieldDefinition) field.getDefinition()).getPackageName();
+    }
+    return TagCategory.other.getPackageName();
+  }
+
+  private TagCategory getTagCategory(PicaFieldDefinition field) {
+    switch (field.getTag().substring(0, 1)) {
+      case "0": return TagCategory.pica0;
+      case "1": return TagCategory.pica1;
+      case "2": return TagCategory.pica2;
+      default:
+        return TagCategory.other;
+    }
+  }
+
   private FieldPath parse(String path) {
     String[] parts = path.split(separator);
     if (parts.length == 1) {

diff --git a/src/main/java/de/gwdg/metadataqa/marc/definition/tags/TagCategory.java b/src/main/java/de/gwdg/metadataqa/marc/definition/tags/TagCategory.java
@@ -28,7 +28,9 @@ public enum TagCategory {
   bl(20, "bltags", "BL", "Locally defined tags of the British Library", false),
   uva(21, "uvatags", "UvA", "Locally defined tags of University of Amsterdam", false),
   b3kat(22, "b3kattags", "B3Kat", "Locally defined tags of a German union cataogue B3Kat", false),
-  pica(50, "pica", "PICA", "PICA+ tags", false),
+  pica0(50, "pica0", "0...", "PICA+ bibliograhic description", false),
+  pica1(51, "pica1", "1...", "PICA+ holding", false),
+  pica2(52, "pica2", "2...", "PICA+ item", false),
   other(99, "unknown", "unknown", "unknown origin", false)
   ;