PICA: general changes #163

src/test/java/de/gwdg/metadataqa/marc/cli/parameters/ValidatorParametersTest.java

@@ -108,14 +108,18 @@ public void testValidFormat() {
   }
 
   @Test
-  public void testInValidFormat() {
-    String[] arguments = new String[]{"--format", "comma-separated", "a-marc-file.mrc"};
+  public void testInvalidFormat() {
+    String msg = null;
+    ValidatorParameters parameters = null;
+    String[] arguments = new String[]{"--format", "iso", "a-marc-file.mrc"};
     try {
-      ValidatorParameters parameters = new ValidatorParameters(arguments);
-      assertEquals(ValidationErrorFormat.COMMA_SEPARATED, parameters.getFormat());
+      parameters = new ValidatorParameters(arguments);
     } catch (ParseException e) {
-      e.printStackTrace();
+      msg = e.getMessage();
     }
+    assertNull(parameters);
+    assertNotNull(msg);
+    assertEquals("Unrecognized ValidationErrorFormat parameter value: 'iso'", msg);
   }
 
   @Test

src/test/java/de/gwdg/metadataqa/marc/model/validation/ValidationErrorFormatTest.java

@@ -0,0 +1,39 @@
+package de.gwdg.metadataqa.marc.model.validation;
+
+import org.junit.Test;
+import java.util.List;
+
+import static org.junit.Assert.*;
+
+public class ValidationErrorFormatTest {
+
+  @Test
+  public void byFormat() {
+    assertEquals(ValidationErrorFormat.COMMA_SEPARATED, ValidationErrorFormat.byFormat("comma-separated"));
+  }
+
+  @Test
+  public void getName() {
+    assertEquals("csv", ValidationErrorFormat.COMMA_SEPARATED.getName());
+  }
+
+  @Test
+  public void getNames() {
+    assertEquals(List.of("csv", "comma-separated"), ValidationErrorFormat.COMMA_SEPARATED.getNames());
+  }
+
+  @Test
+  public void getLabel() {
+    assertEquals("comma separated", ValidationErrorFormat.COMMA_SEPARATED.getLabel());
+  }
+
+  @Test
+  public void values() {
+    assertEquals(4, ValidationErrorFormat.values().length);
+  }
+
+  @Test
+  public void valueOf() {
+    assertEquals(ValidationErrorFormat.COMMA_SEPARATED, ValidationErrorFormat.valueOf("COMMA_SEPARATED"));
+  }
+}