Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for on-demand subtitles #1305

Merged
merged 5 commits into from Dec 22, 2023

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Nov 21, 2023

Description

Changes:

  • New methods Video.searchSubtitles to search for on-demand subtitles and Video.downloadSubtitltes to download on-demand subtitles.
  • Cleaned up uploadSubtitle and removeSubtitles methods and updated doc strings.

Breaking change:

  • Added subtitleStream as first argument to Video.removeSubtitles.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@blacktwin
Copy link
Collaborator

blacktwin commented Nov 25, 2023

Flipping through the hearingImpaired and forced value combinations while searching for subtitles and SubtitleStream() should probably get additional attributes for hearingImpaired and perfectMatch. Both seem to either not exist or exist with the value of 1.

@JonnyWong16
Copy link
Collaborator Author

Added the hearingImpaired attribute (bool) which will always be True / False. This matches the forced attribute.

Added the perfectMatch attribute (bool) which will be None / True. I did not want this flag to be False because that can be misleading for subtitles that are not downloaded on-demand.

@glensc
Copy link
Contributor

glensc commented Dec 4, 2023

downloadSubitltes typo

@JonnyWong16 JonnyWong16 merged commit d4426da into pkkid:master Dec 22, 2023
5 checks passed
@JonnyWong16 JonnyWong16 deleted the feature/on_demand_subtitles branch February 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants