Run tests over unclaimed server #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've suddenly got an idea on how to rewrite this, sorry, I'll create another PR as soon as I'll finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some extra checks and now we have an additional run of tests in Travis: over unclaimed server. You can check out how it looks on my fork's build: https://travis-ci.org/andrey-yantsen/python-plexapi/builds/428930904.
With this PR tests will be ran over PRs, they'll automatically run with unclaimed server.
Also, since we're not using an external server for testing anymore, maybe we can disable Limit concurrent jobs in travis? I'm guessing it's enabled now, because the jobs are running one-by-one.