Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numpy dependency #26

Closed
shopro opened this issue Nov 11, 2017 · 2 comments
Closed

Numpy dependency #26

shopro opened this issue Nov 11, 2017 · 2 comments

Comments

@shopro
Copy link

shopro commented Nov 11, 2017

reader.py on line 10 is importing Numpy but it isn't needed/used in the module. Seems to be a leftover from old code that is causing errors since it's not installed.
@pklaus pklaus closed this as completed in 32ba70b Jan 6, 2018
@pklaus
Copy link
Owner

pklaus commented Jan 6, 2018

Thanks for reporting this. I removed the dependency in commit 32ba70b and the next release will contain the fix.

@pklaus
Copy link
Owner

pklaus commented Feb 20, 2018

Thanks again for reporting. The fix is now part of the latest release v0.8.4.

Lynnaut pushed a commit to Lynnaut/brother_ql2 that referenced this issue Jan 17, 2023
@matmair @kku1993 @Lynnaut
Use 400 byte invalidate command for QL-8XX models. (pklaus#26)
f27c2dc 
QL-800, QL-810W, and QL-820NWB need 400 byte long invalidate commands,
as seen on page 5 of the manual [1].

This PR specifically avoids the use of the deprecated devicedependent
module.

[1] https://download.brother.com/welcome/docp100278/cv_ql800_eng_raster_100.pdf

Co-authored-by: Kevin Ku <kku1993dev@gmail.com>
fuzeman pushed a commit to fuzeman/brother-label that referenced this issue Aug 31, 2023
@matmair @kku1993
Use 400 byte invalidate command for QL-8XX models. (pklaus#26)
2d122e1 
QL-800, QL-810W, and QL-820NWB need 400 byte long invalidate commands,
as seen on page 5 of the manual [1].

This PR specifically avoids the use of the deprecated devicedependent
module.

[1] https://download.brother.com/welcome/docp100278/cv_ql800_eng_raster_100.pdf

Co-authored-by: Kevin Ku <kku1993dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pklaus @shopro