Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: GitHook Linting 적용 에러 및 린팅 룰 재 설정 #20

Closed
4 tasks done
jeongjaino opened this issue Oct 5, 2023 · 1 comment
Closed
4 tasks done

[FIX]: GitHook Linting 적용 에러 및 린팅 룰 재 설정 #20

jeongjaino opened this issue Oct 5, 2023 · 1 comment
Assignees
@jeongjaino
Labels
🔨픽스🔨 버그 및 잠재적 문제 해결 🚀진호🚀 ESTP 정진호 23세

Comments

@jeongjaino
Copy link
Member

jeongjaino commented Oct 5, 2023 •
edited
Loading

작업 사항

문제 상황

  1. Git Hook으로 정한 pre-commit이 실행이 되지 않음 -> 권한 문제로 추정
  2. 컨벤션상 맞는 문법임에도, 린팅오류로 인식함.

1 해결안 : GitHook을 수정 or 다른 방법 Task 실행 시 같이 실행되도록
2 해결안 : editor Rule을 설정

Todo

  • 린팅룰 수정
  • Git Action 임시 수정
  • 전체 모듈 단위에서 린팅 포매팅이 작동 되도록 수정
  • pre-commit script 수정

기타사항

No response
@jeongjaino jeongjaino added the 🌱기능🌱 새로운 기능 두두둥장! label Oct 5, 2023
@jeongjaino jeongjaino self-assigned this Oct 5, 2023
@jeongjaino jeongjaino added 🔨픽스🔨 버그 및 잠재적 문제 해결 and removed 🌱기능🌱 새로운 기능 두두둥장! labels Oct 5, 2023
@jeongjaino jeongjaino mentioned this issue Oct 5, 2023
Merged
@jeongjaino
Copy link
Member Author

https://pinterest.github.io/ktlint/0.49.1/rules/configuration-ktlint/

jeongjaino added a commit that referenced this issue Oct 5, 2023
@jeongjaino
린팅 에러 #20 이슈로 일시적으로 action에서 린팅 주석처리
0367abd
@tgyuuAn tgyuuAn added 🚀진호🚀 ESTP 정진호 23세 🔥핫픽스🔥 릴리즈 후 프로덕션 레벨로 올리기 전 수정작업 and removed 🔨픽스🔨 버그 및 잠재적 문제 해결 labels Oct 7, 2023
@jeongjaino jeongjaino added 🔨픽스🔨 버그 및 잠재적 문제 해결 and removed 🔥핫픽스🔥 릴리즈 후 프로덕션 레벨로 올리기 전 수정작업 labels Oct 9, 2023
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
린트 재가동 삐비빅 #20
7567f5a
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : argument 분리, 상속관계 스페이스 분리
1c78e2b
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : add final line
f56bc29
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : add final line
c4a70b0
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : add trailing comma
6a1d893
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : add trailing comma
cdd89d0
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[FIX] #20 : git hooks pre-commit 스크립트 수정 : 커밋 전 포맷팅에서 체크로 변경
67f65c9
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[FIX] #20 : app 모듈 ktlint 소거 및 pre-commmit 권한 설정 Task 구현 및 등록
b0642c8
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[FIX] #20 : ktLint와 추가적으로 custom rule 추가
401cc89
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[FIX] #20 : app module -> allProject 단의 ktLint 수행하도록 수정
9be5171
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : Test Assertion WildCard Import 수정
06f09e2
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : Add Trailing Comma
2b4aefe
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : Add Final Line
ec84175
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : Import Ordering 수행
b1c28b1
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : Indent 사이즈 수정
64eefc1
jeongjaino added a commit that referenced this issue Oct 9, 2023
@jeongjaino
[STYLE] #20 : ktlint -> ktlint-gradle 이름 변경
ba03f6e
@jeongjaino jeongjaino mentioned this issue Oct 9, 2023
Merged
jeongjaino added a commit that referenced this issue Oct 10, 2023
@jeongjaino
Merge pull request #27 from pknu-wap/fix/jaino/#20
381b6df 
Fix/jaino/#20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeongjaino jeongjaino

Labels
🔨픽스🔨 버그 및 잠재적 문제 해결 🚀진호🚀 ESTP 정진호 23세
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeongjaino @tgyuuAn