Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/tgyuu/#134 #138

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Refactor/tgyuu/#134 #138

merged 5 commits into from
Feb 26, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Feb 23, 2024 •
edited
Loading

1. πŸ“„ κ΄€λ ¨λœ 이슈 및 μ†Œκ°œ

closed #139
closed #134
closed #133

@Redish03 @gjsk132 두 λΆ„κ»˜ κ°μ‚¬λ“œλ¦½λ‹ˆλ‹€ (__)

2. πŸ”₯ λ³€κ²½λœ 점

ν”„λ‘œν•„ 더보기 계정 μ„€μ •, 더 보기 μ˜†μ˜ 이미지 μ•„μ΄μ½˜ 수직 κ°€μš΄λ° μ •λ ¬ μ•ˆλ˜μ–΄ 있던 κ±° κ°€μš΄λ° μ •λ ¬ ν–ˆμ”λ‹ˆλ‹€.

image




μ„€λ¬Έ 응닡 νŽ˜μ΄μ§€ 행사 overview νŽ˜μ΄μ§€μ—μ„œ 행사 EditText κ°€μš΄λ° μ •λ ¬ μ•ˆλ˜μ–΄ 있던 κ±° μˆ˜μ • ν–ˆμŠ΅λ‹ˆλ‹€.




μΆœμ„ μ½”λ“œ 등둝 및 μΆœμ„ν•  λ•Œ, 이벀트 이름이 λ„ˆλ¬΄ κΈΈ 경우 ν…μŠ€νŠΈκ°€ κ°€μš΄λ° μ •λ ¬λ˜μ§€ μ•Šλ˜ 버그 μˆ˜μ •ν•˜μ˜€μ”λ‹ˆλ‹€.

μΆœμ„ μ½”λ“œ 등둝 및 μΆœμ„ ν™”λ©΄μ—μ„œ 이벀트 이름이 κΈΈ 경우 뒀에 μ€„μž„λ§λ‘œ ν‘œμ‹œν•˜λ„λ‘ λ³€κ²½ν–ˆμ”λ‹ˆλ‹€.

image




μΆœμ„ μ„±κ³΅ν–ˆμ„ 경우 λ°”λ‘œ UIλ₯Ό κ°±μ‹ ν•˜λ„λ‘ λ³€κ²½ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

3. βœ… κΌ­ ν™•μΈν•΄μ€¬μœΌλ©΄ ν•˜λŠ” λΆ€λΆ„

4. πŸ“Έ μŠ€ν¬λ¦°μƒ·(선택)

5. πŸ’‘μ•Œκ²Œλœ ν˜Ήμ€ κΆκΈˆν•œ 사항듀

@tgyuuAn tgyuuAn added πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ”§λ¦¬νŒ©ν„°λ§πŸ”§ λ¦¬νŒ©ν„°λ§μΌκΉŒμš” λ¦¬νŒ©ν† λ§μΌκΉŒμš”? πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ labels Feb 23, 2024
@tgyuuAn tgyuuAn self-assigned this Feb 23, 2024
jeongjaino
jeongjaino approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@jeongjaino jeongjaino added the πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. label Feb 26, 2024
@tgyuuAn tgyuuAn merged commit 79015c9 into develop Feb 26, 2024
@tgyuuAn tgyuuAn deleted the refactor/tgyuu/#134 branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ”§λ¦¬νŒ©ν„°λ§πŸ”§ λ¦¬νŒ©ν„°λ§μΌκΉŒμš” λ¦¬νŒ©ν† λ§μΌκΉŒμš”? πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ
Projects
None yet
Milestone
No milestone
2 participants
@tgyuuAn @jeongjaino