-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tgyuu/#141 #145
Feature/tgyuu/#141 #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ๊ท์ ๋ฆ์ด์ ์ฃ์กํด์ ํ๊ตฌ
๋ถ์ฐ์ ๋ด๋ ค์ค๋๋ฐ ์๊ฐ๋ ๋ง์ด ๊ฑธ๋ฆฌ๊ตฌ ,,, (์ฃผ์ ๋ฆฌ์ฃผ์ ๋ฆฌ ํ๊ณ)
๋ช๊ฐ ์ฝ๋ฉํธ ๋จ๊ฒจ๋ดฃ์ด์ฉ ํํ
์๊ฒฌ ๊ธฐ๋ค๋ฆด๊ฒ์ฉ !
@@ -0,0 +1,5 @@ | |||
package com.wap.wapp.core.data.repository.auth | |||
|
|||
interface SignUpRepository { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ๊ท์ ์๋ง
์ฌ๊ฐ SignInRepository๋ฅผ ๋ฐ๋ก ๋ง๋ค์ด๋์ ๊ทธ๊ฑฐ๋ณด๊ณ ์๋กญ๊ฒ ํด๋์ค๋ฅผ ๋ฐ๋ก ๋ง๋์ ๊ฑธ๋ก ์ถ์ธก์ด ๋๋๋ฐ์ฉ ,,!!
์ ๊ฐ AuthRepository๊ฐ ์์์๋ ๋ฐ๋ก SigninRepo๋ฅผ ๊ตฌ์ฑํ๊ฑด ๋ก๊ทธ์ธ ๋์์ Fragment์์์ ๋์ํด์ ActivityScoped๋ก ์ฃผ์ ํด์ ๋ฐ๋ก ๊ตฌ์ฑํด๋จ์์ด์ !!
๊ทธ๋์ ๋ก๊ทธ์ธ์ ์ ์ธํ ๋๋จธ์ง ์ธ์ฆ ๊ด๋ จ ๋ก์ง์ authRepo๋ก ํต์ผํด์ ๊ตฌ์ฑํ์์ด์ !
์ฌ๊ธฐ๊น์ง๊ฐ ํ์คํ ๋ฆฌ๊ตฌ ๊ทธ๋์ ํ๊ณ ์ถ์ ๋ง์
์ฌ์ค ๋ฐ๋ก ํด๋์ค๋ฅผ ํ๋ ๊ด๊ณ๋ ์๋๋ฐ,
AuthRepo๋ก ์ฝ๋์ธ์ฆ ๋ฉ์๋๋ฅผ ๋ฃ๋ ๊ฒ๋ ๊ด์ฐฎ์ ๊ฒ ๊ฐ์์์ !
ํ๊ท์์ ์๊ฒฌ์ด ๊ถ๊ธํฉ๋๋ค ใ ใ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeongjaino ์คํธ ์ ํํฉ๋๋ค.
AuthRepository์์ ์ฐจ๊ณก์ฐจ๊ณก ๋ฃ์ด๋ณด๊ฒ ์ต๋๋ค
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์ฌ๊ธฐ ์์ ์๋ฃํ์๋๋ค!
dataSource์ชฝ๋ ๋ง์ฐฌ๊ฐ์ง๋ผ์ AuthDataSource๋ก ๋ฃ์์ด์!
class SignUpRepositoryImpl @Inject constructor( | ||
private val signUpDataSource: SignUpDataSource, | ||
) : SignUpRepository { | ||
override suspend fun validationWapCode(code: String): Result<Boolean> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ฉ์๋ ๋ค์ด๋ฐ์ด ๋ช ์ฌ์์๋ณด๋ค๋ ๋์ฌ๋ก ์์ํ๋๊ฒ ๋ซ์ง ์์๊น์ !?
๊ทธ๋ฆฌ๊ตฌ wapCode๋ ์ข์ ๊ฒ ๊ฐ๊ธดํ๋ฐ (์ ๋์๋ฆฌ๋ฅผ ์ธ์ฆํ๋๊ฑฐ๋๊น)
์ ๋ ๋์๋ฆฌ ๊ตฌ์ฑ์ ์ธ์ฆ์ฝ๋๋ผ๋ ์๋ฏธ๋ก memeberCode ์ถ์ฒ๋๋ฆฝ๋๋ค ํํ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeongjaino ํ ์ validation์ผ๋ก ๋์ด์์๊น์... ์์ ํด๋๊ฒ ์๋๋ค!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์ ์๋ฃ ํ์๋๋ค!
_signUpEventFlow.emit(SignUpEvent.ValidationSuccess) | ||
} | ||
|
||
fun postUserProfile() = viewModelScope.launch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ๊ท์ ๋ฐ๋ก ํจ์๋ฅผ ๋ถ๋ฆฌํด์ผ ํ์ง์์๊น์ ?
ํ์์ ๋ฑ๋กํ๋ ๋ก์ง๊ณผ ์ฝ๋๋ฅผ ์ธ์ฆํ๋ ๋ก์ง์ด ํ๋ฒ์ ์ฒ๋ฆฌ๋๊ตฌ
๊ทธ๋์ ๋ฉ์๋ ๋ค์ด๋ฐ๋ ์ ์ ์น ์์๊ฒ ๊ฐ์์
๋ฐ๋ก ๋ถ๋ฆฌํ์๊ตฌ ์ธ์ฆ์ฑ๊ณต์ผ๋๋ง ์ ์ ๋ฑ๋กํ๋ ๋งค์๋๋ง ํธ์ถํ๋ ํ์์ผ๋ก ๋ณ๊ฒฝํ๋ฉด ์ข์ ๊ฒ ๊ฐ์์!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeongjaino ๋ง์๋๋ค ์งํธ์ ์์ ํด๋๊ฒ ์๋๋ค!!
โฆy, AuthDataSource๋ก ๋ณํฉ
@jeongjaino ์์ ์๋ฃ ํ์ต๋๋ค!!!! ๊ผญ ํ์ธํด์คฌ์ผ๋ฉด ํ๋ ๋ถ๋ถ << ์ด๊ฑฐ ์ฒดํฌ ๋ถํ๋๋ ค์! |
9c542c0
to
896f090
Compare
1. ๐ ๊ด๋ จ๋ ์ด์ ๋ฐ ์๊ฐ
2. ๐ฅ ๋ณ๊ฒฝ๋ ์
-์ต์ด ํ์๊ฐ์ ์, ์ ๋ณด๋ฅผ ์ ๋ ฅํ ๋ค WAPํ์ ์ฝ๋๋ฅผ ์ ๋ ฅ ์ฑ๊ณตํด์ผ๋ง ํ์ ๊ฐ์ ์ด ์๋ฃ ๋๋ค.
3. โ ๊ผญ ํ์ธํด์คฌ์ผ๋ฉด ํ๋ ๋ถ๋ถ
์๋ฒฝ์ ๊ธํ๊ฒ ์ฝ๋๋ฅผ ์ง๋๋ผ๊ณ ๋ค์ด๋ฐ์ด ์ข ํ์ ํ๊ฒ ์์ ์๋ ์์ด์. ํ์ธ ๋ฐ๋๋๋ค!
๊ทธ๋ฆฌ๊ณ Manager Codeํ์ธํ๋ ๋ก์ง์ด GetManageMentCode๋ผ๊ณ ๋์ด์๋๋ฐ, ์ค์ ๋ก์ง์ ๋น๊ตํ๋ ๋ก์ง์๋ค๊ฐ Boolean์ ๋ฐ๋๋ผ๊ณ ์. ์ฒดํฌ ๋ถํ๋๋ฆฝ๋๋ค!!
4. ๐ธ ์คํฌ๋ฆฐ์ท(์ ํ)
5. ๐ก์๊ฒ๋ ํน์ ๊ถ๊ธํ ์ฌํญ๋ค
Android Compose Navigatoin ์ด๋ ์, ๋ฐฑ์คํ์ ๋ชจ๋ ์ง์ฐ๊ณ ์ถ์ ๋,
์ navOptions์ผ๋ก ๋ฃ์ด์ค๋ค!!!