Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/tgyuu/#148 #149

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Refactor/tgyuu/#148 #149

merged 3 commits into from
Mar 5, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Mar 4, 2024 •
edited
Loading

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

2. ๐Ÿ”ฅ ๋ณ€๊ฒฝ๋œ ์ 

  • ๋ฐ”ํ…€ ์‹œํŠธ, ๋‹ฌ๋ ฅ ์ƒ‰์ƒ์ด ๊ฐ™์•„์„œ ๊ตฌ๋ถ„์ด ์–ด๋ ต๋˜ ์ด์Šˆ ํ•ด๊ฒฐ
  • ๋ฐ”ํ…€์‹œํŠธ ์ƒ๋‹จ์— ๊ทธ๋ฆผ์ž ์ถ”๊ฐ€

3. โœ… ๊ผญ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ๋ถ€๋ถ„

4. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๊ธฐ์กด

image




๋ณ€๊ฒฝ

image

5. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

๋ฐ”ํ…€ ์‹œํŠธ์— ๊ทธ๋ฆผ์ž ์ถ”๊ฐ€ํ•˜๋Š” ๋ฐฉ๋ฒ• ๋งค์šฐ ๊ฐ„๋‹จํ–ˆ๋‹ค...

๋ฐ”ํ…€ ์‹œํŠธ ์†์„ฑ ์ค‘์— sheetShadowElevation = 20.dp ๋กœ ๊ทธ๋ฆผ์ž ๋„ฃ๊ธฐ๋ฅผ ์ œ๊ณตํ•ด์ฃผ๊ณ  ์žˆ์—ˆ๋”ฐ (ํ—ˆ๊ฑฐ๋ฉ)

@tgyuuAn tgyuuAn added ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿ”ง๋ฆฌํŒฉํ„ฐ๋ง๐Ÿ”ง ๋ฆฌํŒฉํ„ฐ๋ง์ผ๊นŒ์š” ๋ฆฌํŒฉํ† ๋ง์ผ๊นŒ์š”? ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Mar 4, 2024
@tgyuuAn tgyuuAn requested a review from jeongjaino March 4, 2024 07:24
@tgyuuAn tgyuuAn self-assigned this Mar 4, 2024
jeongjaino
jeongjaino approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๐Ÿ˜Ž

@jeongjaino jeongjaino added ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. and removed ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Mar 4, 2024
@tgyuuAn tgyuuAn merged commit e986390 into develop Mar 5, 2024
1 check passed
@tgyuuAn tgyuuAn deleted the refactor/tgyuu/#148 branch March 8, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿ”ง๋ฆฌํŒฉํ„ฐ๋ง๐Ÿ”ง ๋ฆฌํŒฉํ„ฐ๋ง์ผ๊นŒ์š” ๋ฆฌํŒฉํ† ๋ง์ผ๊นŒ์š”? ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ
Projects
None yet
Milestone
No milestone
2 participants
@tgyuuAn @jeongjaino