Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace statmod with FastGaussianQuadrature #4

Merged
merged 3 commits into from Sep 30, 2017
Merged

Replace statmod with FastGaussianQuadrature #4

merged 3 commits into from Sep 30, 2017

Conversation

pkofod
Copy link
Owner

@pkofod pkofod commented Sep 29, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 8654ae6 on fgq into dc38058 on master.

@codecov-io
Copy link

codecov-io commented Sep 30, 2017

Codecov Report

Merging #4 into master will decrease coverage by 10.26%.
The diff coverage is 80.95%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
- Coverage    90.9%   80.64%   -10.27%     
===========================================
  Files           1        1               
  Lines          22       31        +9     
===========================================
+ Hits           20       25        +5     
- Misses          2        6        +4
Impacted Files Coverage Δ
src/DistQuads.jl 80.64% <80.95%> (-10.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc38058...b0a4206. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling a175fda on fgq into dc38058 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling a175fda on fgq into dc38058 on master.

@coveralls
Copy link

coveralls commented Sep 30, 2017

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 66a565c on fgq into dc38058 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 827710d on fgq into dc38058 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 827710d on fgq into dc38058 on master.

@pkofod
Copy link
Owner Author

pkofod commented Sep 30, 2017

@ajt60gaibb is there a reason N has to be Int64? It made an older version of this fail with

Gamma: Error During Test
  Got an exception of type MethodError outside of a @test
  MethodError: no method matching gausslaguerre(::Int32, ::Float64)
  Closest candidates are:
    gausslaguerre(!Matched::Int64, ::Float64) at C:\Users\appveyor\.julia\v0.6\FastGaussQuadrature\src\gausslaguerre.jl:9
    gausslaguerre(!Matched::Int64, ::Float64, !Matched::AbstractString) at C:\Users\appveyor\.julia\v0.6\FastGaussQuadrature\src\gausslaguerre.jl:9
    gausslaguerre(!Matched::Int64, ::Float64, !Matched::AbstractString, !Matched::Float64) at C:\Users\appveyor\.julia\v0.6\FastGaussQuadrature\src\gausslaguerre.jl:9

though I now manually convert

@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling e81726c on fgq into dc38058 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling e81726c on fgq into dc38058 on master.

@pkofod
Copy link
Owner Author

pkofod commented Sep 30, 2017

I'll just let it fail on 32bit until FastGaussQuadrature works

@pkofod pkofod merged commit e1b6132 into master Sep 30, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 18ca113 on fgq into dc38058 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.3%) to 80.645% when pulling 18ca113 on fgq into dc38058 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants