Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fallback to symbolic links #203

Merged
merged 1 commit into from
Jun 4, 2023
Merged

Conversation

pkolaczk
Copy link
Owner

@pkolaczk pkolaczk commented Jun 4, 2023

Falling back to softlinks between different devices is dangerous and can lead to data loss. It is better to just fail and let the user specify if they want symbolic links manually.

Now fclones will attempt to create hard links only within the same filesystem.

Fixes #196

@pkolaczk pkolaczk force-pushed the dont-create-cross-device-links branch from e14873f to 9a54945 Compare June 4, 2023 18:06
Falling back to symbolic links between different devices
is dangerous and can lead to data loss.

Now fclones will attempt to create hard links only
within the same filesystem.

Fixes #196
@pkolaczk pkolaczk force-pushed the dont-create-cross-device-links branch from 9a54945 to 76861e3 Compare June 4, 2023 19:16
@pkolaczk pkolaczk merged commit 84ca11b into main Jun 4, 2023
1 check passed
@pkolaczk pkolaczk deleted the dont-create-cross-device-links branch June 4, 2023 19:20
@th1000s
Copy link
Contributor

th1000s commented Jun 4, 2023

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

23000 symlinks created...?
2 participants