Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The unescape() returns España or González instead of España or González #15

Closed
michaelandrewrm opened this issue Sep 3, 2021 · 1 comment
Closed

The unescape() returns España or González instead of España or González #15

michaelandrewrm opened this issue Sep 3, 2021 · 1 comment

Comments

@michaelandrewrm
Copy link

pdf417-generator/lib/pdf417.js

Line 436 in bf1894d

code = unescape(encodeURIComponent(code)); // covert UTF-8 to ISO-8859-1

@michaelandrewrm michaelandrewrm changed the title The unescape() returns España or González instead of España or González, to decode URIs why not use decodeURI() instead? The unescape() returns España or González instead of España or González Sep 3, 2021
pkoretic pushed a commit that referenced this issue Sep 11, 2021
remove UTF-8 to ISO-8859-1, fixes #13, #15
f107972
@pkoretic
Copy link
Owner

Can you try the latest version? This shouldn't be valid actually anymore as UTF-8 is preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkoretic @michaelandrewrm