Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection string interpreted literally #7

Closed
murtyjones opened this issue Jun 16, 2018 · 4 comments
Closed

Connection string interpreted literally #7

murtyjones opened this issue Jun 16, 2018 · 4 comments
Assignees
Labels
area/core Refers to Mongo Seeding library 🐛 bug Label used for changelog generation from PRs

Comments

@murtyjones
Copy link

murtyjones commented Jun 16, 2018

First of all, great library! This is such a common use case that I can't believe there aren't go-to solutions out there. Hopefully this library becomes one.

I noticed that when using a connection string, e.g. /test?retryWrites=true, it should reference an existing database named test in mongo, but instead results in a new database being created with the name /test?retryWrites=true. Seems like the params from the ? on are being interpreted literally. Don't know if it's an issue with this library or a dependency.

@pkosiec
Copy link
Owner

pkosiec commented Jun 16, 2018

Hello @murtyjones,
Thank you for kind words!
Yes, I confirm, this is a bug in mongo-seeding. I will try to fix it in a few hours and release a new version 🙂

@pkosiec pkosiec added the 🐛 bug Label used for changelog generation from PRs label Jun 16, 2018
@pkosiec pkosiec added this to To Do in Mongo Seeding via automation Jun 16, 2018
@pkosiec pkosiec self-assigned this Jun 16, 2018
Mongo Seeding automation moved this from To Do to Done Jun 16, 2018
@pkosiec
Copy link
Owner

pkosiec commented Jun 16, 2018

I've fixed the error and updated dependencies, but unfortunately I cannot do the release right now because of the following issue: DefinitelyTyped/DefinitelyTyped#26594
Can we wait a bit for a new release of mongo types? I think it will take one day at most. If this is urgent for you, then I can downgrade them and release new version.

Thanks for using mongo-seeding!

@murtyjones
Copy link
Author

Thanks for the quick fix! In my case, ?retryWrites=true wasn't needed so I just took it out.

@pkosiec
Copy link
Owner

pkosiec commented Jun 20, 2018

Just a quick note: The new version of Mongo Seeding has been just released!

@pkosiec pkosiec added the area/core Refers to Mongo Seeding library label Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core Refers to Mongo Seeding library 🐛 bug Label used for changelog generation from PRs
Projects
Status: Done
Mongo Seeding
  
Done
Development

No branches or pull requests

2 participants