Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mongodb] use T as type rather than value #26594

Merged
merged 1 commit into from Jun 18, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Jun 15, 2018

A recent change made T a value rather than a type. This PR fixes this.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 16, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 16, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 16, 2018

@kjin Thank you for submitting this PR!

🔔 @CaselIT @alanmarcell @kikar @bitjson @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jun 16, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 16, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@ravihugo
Copy link
Contributor

ravihugo commented Jun 16, 2018

I just updated to the latest version and started getting this error:
node_modules/@types/mongodb/index.d.ts(1255,24): error TS7006: Parameter 'T' implicitly has an 'any' type.

Presumably from this commit? Not sure if anyone else is seeing this.

Workaround:
npm i -D @types/mongodb@3.0.18

Edit: I originally mistakenly thought this PR was the cause - but it's actually the fix.. just waiting for @types/mongodb to get this update.

@CaselIT
Copy link
Contributor

CaselIT commented Jun 16, 2018

This should fix it

@adriang133
Copy link
Contributor

@ravihugo Strangely, I don't get an error when I run tsc locally, but when I deploy to Heroku I get that error. Tried 3.0.18 also, but still get the same :(

@GingerLoaf
Copy link

So this error was fixed on the 15th and it is now the 18th, and I still see the latest npm version at 3.0.20 (https://www.npmjs.com/package/@types/mongodb). How long does it usually take for this to propagate to npm?

@kjin
Copy link
Contributor Author

kjin commented Jun 18, 2018

@GingerLoaf I think it gets published automatically after someone merges it. So hopefully, some time today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants