New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mongodb] use T as type rather than value #26594
Conversation
@kjin Thank you for submitting this PR! 🔔 @CaselIT @alanmarcell @kikar @bitjson @Dante-101 @mcortesi @EnricoPicci @AJCStriker @julien-c @daprahamian - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
I just updated to the latest version and started getting this error: Presumably from this commit? Not sure if anyone else is seeing this. Workaround: Edit: I originally mistakenly thought this PR was the cause - but it's actually the fix.. just waiting for |
This should fix it |
@ravihugo Strangely, I don't get an error when I run tsc locally, but when I deploy to Heroku I get that error. Tried 3.0.18 also, but still get the same :( |
So this error was fixed on the 15th and it is now the 18th, and I still see the latest npm version at 3.0.20 (https://www.npmjs.com/package/@types/mongodb). How long does it usually take for this to propagate to npm? |
@GingerLoaf I think it gets published automatically after someone merges it. So hopefully, some time today. |
A recent change made
T
a value rather than a type. This PR fixes this.npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).