Makefile changes #47
Merged
Makefile changes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recursive approach used before is deperecated, new one reflects the suggested behaviour ( see https://www.gnu.org/software/make/manual/make.html#Phony-Targets ). Now errors in sub-makes are tracked correctly.
If make install is used more than once, an error will rise, since ln cannot overwrite an already existing symbolic link. This is not a problem while copying files in place, since cp -f will overwrite them anyway. Now the link is not created if already there.
Now the copy operation to /usr/src of the needed files is performed by dkms. This way, the module is recompiled by dkms immediately, and installed for the running kernel. Since the modules does not need to be already compiled, a make clean operation is performed before dkms-install/dkms-uninstall. Since dkms will install the compiled modules in its dir tree, a make uninstall operation is invoked too, so that only the modules compiled by dkms will remain installed in the system. This happens on both dkms-install and dkms-uninstall. The missing 'all' dependency was added to the install target. The PWD variable was not appropriate, since was read by make from the shell and never changed upon recursive make -C invocations. CURDIR variable is an internal make variable, which is updated to reflect the real current working directory.
|
@Shub77, thank you again for your contribution to this project. It is greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These four commits change some Makefiles and add missing double quotes in
dkms.conffile.The commit messages detail the changes.
Regards